Conversation
srid
added a commit
to juspay/vira
that referenced
this pull request
Aug 21, 2025
This change extends multi-home units to work with tests as well. We first make vira tests a proper spec (not executable), and then add that to --enable-multi-repl so that the tests re-compile when the library sources change. This option is define in one place, ./cabal-repl. We could potentially nixify this using srid/haskell-flake#449 Also, the tests no longer build in Nix for vira, as they require network. Instead the Github workflow runs them through cabal.
srid
added a commit
to juspay/vira
that referenced
this pull request
Aug 21, 2025
This change extends multi-home units to work with tests as well. We first make vira tests a proper spec (not executable), and then add that to --enable-multi-repl so that the tests re-compile when the library sources change. This option is define in one place, ./cabal-repl. We could potentially nixify this using srid/haskell-flake#449 Also, the tests no longer build in Nix for vira, as they require network. Instead the Github workflow runs them through cabal.
Owner
Author
|
Should probably rename this to
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let's leave this as draft until I figure out a good way to use this for multi home units DX (see referenced PR below).